Lesson 8: Refactoring for the Feels: Identifying and Removing Bad Smells

Code 'smells' are indicators that something is wrong in the system design, even if the code executes correctly. Identifying and fixing these smells is core to maintaining a positive code vibe.

Common Code Smells (Bad Vibe Triggers)

1. Long Method: Functions that exceed the mental capacity of a reviewer (covered in Lesson 7).
2. Duplicated Code: Identical or nearly identical blocks of code appearing in multiple places. (Fix: Extract to a shared utility function).
3. Large Class/Module: A class or file that contains too many responsibilities, variables, or functions. (Fix: Split into smaller, more focused classes).
4. Feature Envy: A method in Class A spends more time interacting with the data of Class B than its own data. (Fix: Move the method to Class B).
5. Shotgun Surgery: A change in one part of the system requires many tiny modifications across numerous files. (Fix: Centralize the logic being changed).

The Refactoring Mindset

Refactoring is not fixing bugs; it is improving the internal structure of code without changing its external behavior. It should be done constantly, not just once a year.

Vibe Tip: The moment you spot a smelly piece of code while adding a new feature, take 5 minutes to refactor it. Leave the area cleaner than you found it.

Safe Refactoring Steps

1. Write/Verify Tests: Ensure you have tests covering the behavior of the code you plan to change.
2. Make Small, Atomic Changes: Rename a variable, extract a function, move a file. Commit frequently.
3. Run Tests: Verify that the external behavior is unchanged.
4. Repeat: Continuously improve until the vibe is clean.